Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prettier version #867

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Update prettier version #867

merged 1 commit into from
Apr 10, 2023

Conversation

gorkem
Copy link
Collaborator

@gorkem gorkem commented Apr 2, 2023

What does this PR do?

Updates prettier to 2.8.7. Fix the problems with the lint rules that were introduced with this release

What issues does this PR fix or reference?

redhat-developer/vscode-yaml#255

Is it tested? How?

Existing test set

@coveralls
Copy link

coveralls commented Apr 2, 2023 •
edited
Loading

Coverage Status

Coverage: 83.304%. Remained the same when pulling c8218aa on gorkem:update-prettier into 319aaf4 on redhat-developer:main.

@gorkem
Update prettier version
c8218aa 
Updates prettier to 2.8.7. Fix the problems the lint
rules that was introduced with this release
msivasubramaniaan
msivasubramaniaan approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msivasubramaniaan msivasubramaniaan merged commit cf3f792 into redhat-developer:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msivasubramaniaan msivasubramaniaan msivasubramaniaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gorkem @coveralls @msivasubramaniaan